Re: [PATCH] mm: do not use page_count without a page pin

From: Andrea Arcangeli
Date: Wed Jun 13 2012 - 21:21:08 EST


On Tue, Jun 12, 2012 at 07:49:34AM +0900, Minchan Kim wrote:
> If THP page isn't LRU and it's still PageTransHuge, I think it's rather rare and
> although it happens, it means migration/reclaimer is about to split or isolate/putback
> so it ends up making THP page movable pages.
>
> IMHO, it would be better to account it by movable pages.
> What do you think about it?

Agreed. Besides THP don't fragment pageblocks. It was just about
speeding up the scanning the same way it happens with the pagebuddy
check, but probably not worth it because we're in a racy area here not
holding locks. pagebuddy is safe because the zone lock is hold, or
it'd run in the same problem.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/