Re: [PATCH] staging: zsmalloc: fix uninit'ed variable warning

From: Minchan Kim
Date: Wed Jun 13 2012 - 21:35:45 EST


Hi Seth,

On 06/14/2012 06:03 AM, Seth Jennings wrote:

> This patch fixes an uninitialized variable warning in
> alloc_zspage(). It also fixes the secondary issue of
> prev_page leaving scope on each loop iteration. The only
> reason this ever worked was because prev_page was occupying
> the same space on the stack on each iteration.
>
> Signed-off-by: Seth Jennings <sjenning@xxxxxxxxxxxxxxxxxx>


Nice catch!

Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

Nitpick:
I can't see the warning.
My gcc version is gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3.

Please, Cced linux-mm, too.
Some guys in mm might have a interest in zsmalloc. :)

--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/