Re: [PATCH 2/2 v2][resend] gpio: pcf857x: enable gpio_to_irq() support

[Kuninori Morimoto]

Hi Paul

> On Thu, Jun 14, 2012 at 12:10:59AM -0700, Kuninori Morimoto wrote:
> > +	for (i = 0; i < gpio->chip.ngpio; i++)
> > +		if (change & BIT(i))
> > +			generic_handle_irq(irq_find_mapping(gpio->irq_domain, i));
> > +
> You can probably get away with using for_each_set_bit() as well, which
> would simplify this a bit.
> 
> Also, do you not have to worry about masking the parent IRQ while
> iterating through the dispatch loop?

This device automatically stops its IRQ until data was read.
And it is using spin_lock_irqsave(), and it needs to save prev status.
So, I guess masking parent IRQ is not needed.
But not enough/good ?

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/