Re: [PATCH 2/4] x86: Track minimum microcode revision globally v2

[Borislav Petkov]

On Wed, Jun 13, 2012 at 01:20:40PM -0700, Andi Kleen wrote:
> +void update_min_microcode(struct cpuinfo_x86 *c)
> +{
> +	int i;
> +
> +	for_each_online_cpu (i)
> +		if (cpu_data(i).microcode < c->microcode)
> +			return;
> +	if (boot_cpu_data.microcode != c->microcode) {
> +		boot_cpu_data.microcode = c->microcode;
> +		pr_info("Minimum microcode revision updated to %x\n", c->microcode);

This needs to be stating explicitly that the ucode version is in hex -
0x%x - as everywhere else in the kernel where we output ucode version.

Ditto for the remaining printks which will end up in the final version
of your patchset.

-- 
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/