Re: [PATCH] reboot: disable nonboot CPUs

From: Cyrill Gorcunov
Date: Thu Jun 14 2012 - 17:48:44 EST


On Thu, Jun 14, 2012 at 02:41:48PM -0700, Kees Cook wrote:
> On Thu, Jun 14, 2012 at 2:25 PM, Per Forlin <per.forlin@xxxxxxxxxxxxxx> wrote:
> > Disable the nonboot CPUs to safely migrate tasks and interrupts
> > to the boot CPU. This will prevent the nonboot CPUs to
> > interfer or block the boot CPU from being able to reboot
> > the system successfully.
>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> This seems reasonable to me, though I haven't looked too deeply at the
> reboot path.

Looks reasonable to me as well, but better to add some more CC,
since syscore_shutdown seems to call for generic irqs to shutdown
when cpu get turned off already, not sure if this have any side
effect and/or I've missed something (Thomas CC'ed).

Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/