Re: [PATCH] PM: Deprecate suspend/resume in device_driver

[Ning Jiang]

2012/6/15 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>:
> On Thu, Jun 14, 2012 at 09:15:47PM +0200, Rafael J. Wysocki wrote:
>> On Thursday, June 14, 2012, Greg KH wrote:
>> > On Thu, Jun 14, 2012 at 02:42:17PM +0800, ning.n.jiang@xxxxxxxxx wrote:
>> > > From: Ning Jiang <ning.n.jiang@xxxxxxxxx>
>> > >
>> > > Make suspend/resume callbacks in device_driver deprecated and scheduled
>> > > for removal since they are not used in PM core anymore.
>> > >
>> > > Legacy drivers who still use them need to move suspend/resume callbacks
>> > > to dev_pm_ops.
>> >
>> > How many complier warnings does this patch produce?
>> >
>> > Please fix them before submitting this patch.  The way kernel
>> > development is is that you fix the problems up with the api, you don't
>> > just mark them and hope someone else will do it for you.
>> >
>> > Sorry, I can't take this.
>>
>> Right.
>
> To provide a bit more "constructive" review, the proper thing is to fix
> up the whole kernel to never set these fields, and then just delete
> them.  Ning, feel free to start working on that task, it's a good one to
> accomplish and should be pretty well defined.

All right. I'm working on it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/