Re: [PATCH 04/10] fblog: implement fblog_redraw()

From: Alan Cox
Date: Sat Jun 16 2012 - 18:32:27 EST


On Sun, 17 Jun 2012 00:04:20 +0200
David Herrmann <dh.herrmann@xxxxxxxxxxxxxx> wrote:

> This mostly copies the functionality from drivers/video/console/bitblit.c
> so we can draw the console content on all available framebuffers.
>
> All speed optimizations have been removed for simplicity. The original
> code depends heavily on CONFIG_VT so we cannot share the codebase here.

No. That means we've got two sets of code to maintain not one. Fix the
dependancy.

Pull the relevant subset of struct vc_data into another struct
Make struct vc_data be

struct vc_data {
struct vc_whatever
rest
}

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/