Re: [PATCHv2 0/5] remoteproc: Custom firmware handling.

[Ohad Ben-Cohen]

Hi Sjur,

On Mon, Jun 11, 2012 at 8:29 PM,  <sjur.brandeland@xxxxxxxxxxxxxx> wrote:
> Here is a new patch series. I dropped the two bug-fix patches
> since last time, as you already included these. I've tried to
> address all of your review comments since last time, hope I
> didn't miss any.

Thanks, this looks good.

I have a few small mostly-style comments, but I could just do them
while I apply the patches.

I've tried applying the (first four) patches, but since they are still
based on the two bug-fixes patches, they don't apply.

So we can either wait until the bug fixes are merged by Linus (I'm
going to send them soon) or you can rebase the patches on a current
mainline tree (which I could then push to linux-next) - however you
prefer.

> Status:
> I have done a simple simulated test now with the STE firmware
> loader and main-flow seems ok, but I haven't done any negative
> tests.

Ok, thanks. The first four patches seem trivial enough for me to merge
even without any extensive testing.

> - The latest patch is a bit odd. The ste_modem_remoteproc module
>  contains only the firmware handler, and nothing else.

What are your plans regarding the rest of that module? we may want to
wait with the fifth patch until we have some basic functionality.

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/