Re: Driver scsi/lpfc breaks build since 3.4.1

From: Greg KH
Date: Sun Jun 17 2012 - 21:24:47 EST


On Mon, Jun 18, 2012 at 02:09:08AM +0200, Tobias Klausmann wrote:
> Hello there,
> since 3.4.1 the driver scsi/lpfc breaks my build for some unused variables:
> drivers/scsi/lpfc/lpfc_scsi.c: In function âlpfc_bg_setup_bplâ:
> drivers/scsi/lpfc/lpfc_scsi.c:1900:11: error: unused variable ârcâ
> [-Werror=unused-variable]
> drivers/scsi/lpfc/lpfc_scsi.c: In function âlpfc_bg_setup_bpl_protâ:
> drivers/scsi/lpfc/lpfc_scsi.c:2037:11: error: unused variable ârcâ
> [-Werror=unused-variable]
> drivers/scsi/lpfc/lpfc_scsi.c: In function âlpfc_bg_setup_sglâ:
> drivers/scsi/lpfc/lpfc_scsi.c:2256:11: error: unused variable ârcâ
> [-Werror=unused-variable]
> drivers/scsi/lpfc/lpfc_scsi.c: In function âlpfc_bg_setup_sgl_protâ:
> drivers/scsi/lpfc/lpfc_scsi.c:2386:11: error: unused variable ârcâ
> [-Werror=unused-variable]
> cc1: all warnings being treated as errors
>
> From the drivers makefile:
> ccflags-y += -Werror <- this causes the bad behavior.

As has been stated before, this ccflags setting is what needs to be
fixed, not trying to fix up the warnings here (although that is a good
goal overall.)

Also, this isn't how to submit a patch to the stable kernel tree, please
read Documentation/stable_kernel_rules.txt for how to properly do that.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/