Re: [PATCH 14/22 v4] Input: atmel_mxt_ts - don't re-read matrix afterapplying pdata

From: Nick Dyer
Date: Mon Jun 18 2012 - 11:11:17 EST


Daniel Kurtz wrote:
> The matrix x/y size in the Info ID Block represents the number of x/y
> trace lines on the device. There is no need to re-read them after
> applying pdata config, since pdata only configures the object table
> etnries. The matrix size read from the ID can only be updated by a
> firmware update.

This isn't correct. For example, mXT224 can be configured as 16x14, 17x13,
18x12, etc. This only takes effect when the chip is reset, which is why it
is necessary to re-read them after applying the config.

cheers

--
Nick Dyer
Software Engineer, ITDev Ltd
Hardware and Software Development Consultancy
Website: http://www.itdev.co.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/