Re: [PATCH 5/8] Staging: xgifb: Remove XGIFAIL() macro and its calls.

[Miguel Gómez]

> > -	if (!(htotal) || !(vtotal))
> > -		XGIFAIL("XGIfb: no valid timing data");
> > +	if (!(htotal) || !(vtotal)) {
>
> Don't resend this, but next time feel free to write this like:
>
> 	if (!htotal || !vtotal) {
>
> We do have a one change per patch rule but tiny formatting things
> like that don't count as a change.

Sure. I'll write it down together with your other comment to my next 
round of patches ;)

Regards!

--
Miguel Gómez
Igalia - http://www.igalia.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/