RE: [PATCH 1/4] staging: comedi: Kconfig: menuconfig options shouldbe bool not tristate

[H Hartley Sweeten]

On Monday, June 18, 2012 4:59 PM, Greg KH wrote:
> On Fri, Jun 15, 2012 at 03:20:04PM -0700, H Hartley Sweeten wrote:
>> The menuconfig options to enable the misc, isa, pci, pcmcia, and usb
>> comedi driver selections should be bool not tristate. They don't
>> directly affect the building of the kernel they just allow other
>> options to be selected.
>> 
>> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
>> Cc: Ian Abbott <abbotti@xxxxxxxxx>
>> Cc: Frank Mori Hess <fmhess@xxxxxxxxxxxxxxxxxxxxx>
>> ---
>>  drivers/staging/comedi/Kconfig |   10 +++++-----
>>  1 files changed, 5 insertions(+), 5 deletions(-)
>
> This patch breaks the build for me with lots of the following errors:
> ERROR: "subdev_8255_init" [drivers/staging/comedi/drivers/adl_pci7296.ko] undefined!
> ERROR: "subdev_8255_cleanup" [drivers/staging/comedi/drivers/adl_pci7296.ko] undefined!
>
> So I can't take it, or the other 4 patches in this series, sorry.
>
> Care to redo it?

Hmm.. Builds fine for me.

I'll work out the issue and re-posty the patches.

Thanks,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/