Re: [PATCH V2 2/3] regulator: dt: add policy to have property "regulator-compatible"

[Stephen Warren]

On 06/19/2012 08:28 AM, Laxman Dewangan wrote:
> Add the policy for regulator DT such that each regulator child node
> must have the property "regulator-compatible" which matches with
> regulator name of their hardware counterparts.
> Modify the dt documentation of regulator devices to reflect this
> policy.

> diff --git a/Documentation/devicetree/bindings/mfd/tps65910.txt b/Documentation/devicetree/bindings/mfd/tps65910.txt

>    device need to be present. The definition for each of these nodes is defined
>    using the standard binding for regulators found at
>    Documentation/devicetree/bindings/regulator/regulator.txt.
> +  The regulator is matched with the regulator-compatible.

That last sentence should be true for any chip containing multiple
regulators and using the standard regulator binding. As such, shouldn't
that property be part of regulator.txt, rather than each individual
regulator chip's binding document?

> -  The valid names for regulators are:
> +  The valid regulator-compatible for regulators are:

Perhaps "The valid regulator-compatible values are:"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/