Re: [PATCH 08/14] mfd: Add IRQ domain support for the AB8500

[Linus Walleij]

On Mon, Jun 18, 2012 at 12:20 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> On Mon, Jun 18, 2012 at 10:02:53AM +0100, Lee Jones wrote:
>> @@ -361,7 +362,7 @@ static void ab8500_irq_sync_unlock(struct irq_data *data)
>>  static void ab8500_irq_mask(struct irq_data *data)
>>  {
>>       struct ab8500 *ab8500 = irq_data_get_irq_chip_data(data);
>> -     int offset = data->irq - ab8500->irq_base;
>> +     int offset = data->irq;
>
> Are you sure this is right?  I thought irq_data->irq was the Linux IRQ
> number, irq_data->hwirq was the interrupt number inside the domain.

Agree, this need to be fixed and respin...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/