Re: [PATCH -v6 3/4] PCI, PM, Do not call pci_set_power_state with PCI_D3cold

[Rafael J. Wysocki]

On Tuesday, June 19, 2012, Huang Ying wrote:
> PCI subsystem has not been ready for D3cold support yet.  So
> PCI_D3cold should not be used as parameter for pci_set_power_state.
> This patch is needed for upcoming PCI_D3cold support.
> 
> This patch has no functionality change, because pci_set_power_state
> will bound the parameter to PCI_D3hot too.
> 
> Cc: Michal Miroslaw <mirq-linux@xxxxxxxxxxxx>
> Cc: Jesse Barnes <jesse.barnes@xxxxxxxxx>
> Signed-off-by: Huang Ying <ying.huang@xxxxxxxxx>

Reviewed-by: Rafael J. Wysocki <rjw@xxxxxxx>

> ---
>  arch/x86/pci/mrst.c       |    2 +-
>  drivers/misc/cb710/core.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/arch/x86/pci/mrst.c
> +++ b/arch/x86/pci/mrst.c
> @@ -264,7 +264,7 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_IN
>  
>  static void __devinit mrst_power_off_unused_dev(struct pci_dev *dev)
>  {
> -	pci_set_power_state(dev, PCI_D3cold);
> +	pci_set_power_state(dev, PCI_D3hot);
>  }
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0801, mrst_power_off_unused_dev);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0809, mrst_power_off_unused_dev);
> --- a/drivers/misc/cb710/core.c
> +++ b/drivers/misc/cb710/core.c
> @@ -180,7 +180,7 @@ static int cb710_suspend(struct pci_dev
>  	pci_save_state(pdev);
>  	pci_disable_device(pdev);
>  	if (state.event & PM_EVENT_SLEEP)
> -		pci_set_power_state(pdev, PCI_D3cold);
> +		pci_set_power_state(pdev, PCI_D3hot);
>  	return 0;
>  }
>  
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/