Re: [PATCH 2/3] regulator: replace devm_gpio_request_one() forloaded module

From: Mark Brown
Date: Thu Jun 21 2012 - 05:20:23 EST


On Thu, Jun 21, 2012 at 08:03:48AM +0000, Kim, Milo wrote:
> At this moment, devm_gpio_request_one() has not been exported yet.
> But lp872x driver can be used as a module, so related functions should be changed.
>
> devm_gpio_request_one() -> gpio_request_one() and gpio_free()

No, this is a step back in terms of the quality of the driver especially
given that nobody is likely to actually use the driver when built as a
module. We should just wait until the function is exported and then
reenable modular builds.

Attachment: signature.asc
Description: Digital signature