Re: [PATCH 1/3] eCryptfs: Gracefully refuse miscdev file ops oninherited/passed files

From: Sasha Levin
Date: Fri Jun 22 2012 - 13:48:25 EST


On Wed, Jun 13, 2012 at 2:05 AM, Tyler Hicks <tyhicks@xxxxxxxxxxxxx> wrote:
> File operations on /dev/ecryptfs would BUG() when the operations were
> performed by processes other than the process that originally opened the
> file. This could happen with open files inherited after fork() or file
> descriptors passed through IPC mechanisms. Rather than calling BUG(), an
> error code can be safely returned in most situations.
>
> In ecryptfs_miscdev_release(), eCryptfs still needs to handle the
> release even if the last file reference is being held by a process that
> didn't originally open the file. ecryptfs_find_daemon_by_euid() will not
> be successful, so a pointer to the daemon is stored in the file's
> private_data. The private_data pointer is initialized when the miscdev
> file is opened and only used when the file is released.
>
> https://launchpad.net/bugs/994247
>
> Signed-off-by: Tyler Hicks <tyhicks@xxxxxxxxxxxxx>
> Reported-by: Sasha Levin <levinsasha928@xxxxxxxxx>
> Cc: Sasha Levin <levinsasha928@xxxxxxxxx>
> ---

I've been running it a while now and haven't seen the problem I've
reported reproducing.

Is it possible to merge this fix into 3.5?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/