Re: [PATCH] x86, cpufeature: Fix duplicate feature name "dts"

From: Guenter Roeck
Date: Fri Jun 22 2012 - 14:53:34 EST


On Fri, 2012-06-22 at 14:01 -0400, H. Peter Anvin wrote:
> On 06/21/2012 11:59 PM, Ingo Molnar wrote:
> >
> > Plus add a kernel build time check to avoid such string clashes
> > in the future? These acronyms tend to be short and hard to read,
> > I'd not be surprised if this repeated in the future.
> >
>
> Another *MASSIVE* fail is that an x86 cpufeature was added by a patch
> that went through the hwmon tree without any x86 maintainer ACK, and
> with a subject line that would not have made anyone aware of it:
>
> a4659053 x86/hwmon: fix initialization of coretemp
>
> We maintain x86/cpufeature as a separate -tip branch for a reason:
> changes to that stuff mucks with *everything* as it is.

My apologies. Hope I learned a bit since then.

Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/