Re: [PATCH] Taint kernel when lve module is loaded

From: richard -rw- weinberger
Date: Fri Jun 22 2012 - 15:09:19 EST


On Fri, Jun 22, 2012 at 7:49 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
> Cloudlinux have a product called lve that includes a kernel module. This
> was previously GPLed but is now under a proprietary license, but the
> module continues to declare MODULE_LICENSE("GPL") and makes use of some
> EXPORT_SYMBOL_GPL symbols. Forcibly taint it in order to avoid this.
>
> Signed-off-by: Matthew Garrett <mjg59@xxxxxxxxxxxxx>
> Cc: Alex Lyashkov <umka@xxxxxxxxxxxxxx>
> ---
>  kernel/module.c |    4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index 4edbd9c..9ad9ee9 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2730,6 +2730,10 @@ static int check_module_license_and_versions(struct module *mod)
>        if (strcmp(mod->name, "driverloader") == 0)
>                add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
>
> +       /* lve claims to be GPL but upstream won't provide source */
> +       if (strcmp(mod->name, "lve") == 0)
> +               add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
> +

If this kernel module is really lying to us the kernel should simply
refuse to load it and
call a lawyer.

--
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/