Re: pull request: wireless 2012-06-22

From: David Miller
Date: Fri Jun 22 2012 - 19:56:07 EST


From: Sujith Manoharan <c_manoha@xxxxxxxxxxxxxxxx>
Date: Sat, 23 Jun 2012 05:05:10 +0530

> Sujith Manoharan wrote:
>> John W. Linville wrote:
>> > Mohammed Shafi Shajakhan (1):
>> > ath9k_hw: avoid possible infinite loop in ar9003_get_pll_sqsum_dvc
>>
>> Um, this commit doesn't really fix anything - the timeout is also
>> arbitrary. Can you remove this from the 3.5 queue ? Thanks.
>
> A review of the patch later, I think it's good. At least there's a
> WARN_ON_ONCE() to indicate the situation in which the measurement fails.
> It might come in handy as a debugging aid.

Thanks for wasting our time.

Make these determinations when changes to into John's tree, not
later when he asks me to pull them into mine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/