Re: [PATCH 2/2] staging: zram: Remove useless struct zobj_header

From: Dan Carpenter
Date: Sat Jun 23 2012 - 11:19:33 EST


On Thu, Jun 21, 2012 at 12:32:45AM -0300, Marcos Paulo de Souza wrote:
> The struct zobj_header has no members, so the sizeof(struct zobj_header *)
> always returns zero. For this reason we are removing this useless struct.
>

I've been out for the past few days and I'm slowly catching up. If
you want you could update this comment as well:

drivers/staging/zram/zram_drv.h
40 /*
41 * NOTE: max_zpage_size must be less than or equal to:
42 * ZS_MAX_ALLOC_SIZE - sizeof(struct zobj_header)
43 * otherwise, xv_malloc() would always return failure.
44 */

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/