Re: [PATCH V2 1/3] staging/rtl8192u: fix coding style problems

From: Joe Perches
Date: Sat Jun 23 2012 - 16:52:36 EST


On Sun, 2012-06-24 at 00:04 +0530, devendra.aaru wrote:
> Hi Joe,

Hi Devendra.

> On Thu, Jun 21, 2012 at 4:48 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > I'd just make the return a bool instead.

> taking another variable and assign it like bool ret = !!bit, and
> returning ret?, i think this doesn't look better.

No. just
return val;
or
return (bool)val;

if using the implicit conversion bothers you.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/