Re: [RFC patch 5/5] infiniband: ehca: Use hotplug threadinfrastructure

[Thomas Gleixner]

On Mon, 18 Jun 2012, Thomas Gleixner wrote:
> > Your infrastructure is a really weird mix.  On the one hand, it's a set
> > of callbacks: setup, cleanup, park, unpark.  Cool.
> > 
> > On the other hand, instead of a 'run' callback, you've got a thread_fn,
> > which has to loop and call smpboot_thread_check_parking().
> > 
> > If you just had the thread_fn, it'd be trivial to follow program flow.
> > If you just had the callbacks, it'd still be pretty easy, though it
> > seems like a little too much help.

I reread your reply with less sleep depriviation and now I understood
your suggestion for using a run callback :)

Yep, that makes sense as it moves the loop into the generic code. Will
have a go on that.

Thanks,

	tglx



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/