Re: [PATCH] drivers: staging: android: fix binder.c printk macros

From: Joe Perches
Date: Mon Jun 25 2012 - 13:30:05 EST


On Mon, 2012-06-25 at 10:24 -0700, Greg KH wrote:
> On Mon, Jun 25, 2012 at 10:20:00AM -0700, Joe Perches wrote:
> > Your patch-bot needs work.
> >
> > Converting printks to pr_<level> is trivial
> > and should be done all at once, not piecemeal.
>
> I'm not disagreeing with that, unfortunately this patch also did more
> than just pr_<level> conversions, which is why my patch-bot kicked in.
>
> So your patch-bot complaint generator needs work :)

Or not. I think wholesale whitespace changes are just
fine too.

git diff -w can ignore all those things pretty easily.

Using a bot is certainly sensible and sanity-preserving.
I think it just needs a little tweaking.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/