Re: [PATCH 06/11] memcg: kmem controller infrastructure

From: Glauber Costa
Date: Tue Jun 26 2012 - 10:43:34 EST


On 06/26/2012 03:17 AM, Andrew Morton wrote:
}
>+
>+#define mem_cgroup_kmem_on 0
>+#define __mem_cgroup_new_kmem_page(a, b, c) false
>+#define __mem_cgroup_free_kmem_page(a,b )
>+#define __mem_cgroup_commit_kmem_page(a, b, c)
I suggest that the naming consistently follow the model
"mem_cgroup_kmem_foo". So "mem_cgroup_kmem_" becomes the well-known
identifier for this subsystem.

Then, s/mem_cgroup/memcg/g/ - show us some mercy here!

I always prefer shorter names, but mem_cgroup, and not memcg, seems to be the default for external functions.

I am nothing but a follower =)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/