Re: [PATCH 06/11] memcg: kmem controller infrastructure

[Glauber Costa]

On 06/26/2012 10:01 PM, Andrew Morton wrote:
> On Tue, 26 Jun 2012 19:01:15 +0400 Glauber Costa <glommer@xxxxxxxxxxxxx> wrote:
>
> > On 06/26/2012 03:17 AM, Andrew Morton wrote:
> > > > +	memcg_uncharge_kmem(memcg, size);
> > > > > +	mem_cgroup_put(memcg);
> > > > > +}
> > > > > +EXPORT_SYMBOL(__mem_cgroup_free_kmem_page);
> > > > >   #endif /* CONFIG_CGROUP_MEM_RES_CTLR_KMEM */
> > > > >
> > > > >   #if defined(CONFIG_INET) && defined(CONFIG_CGROUP_MEM_RES_CTLR_KMEM)
> > > > > @@ -5645,3 +5751,69 @@ static int __init enable_swap_account(char *s)
> > > > >   __setup("swapaccount=", enable_swap_account);
> > > > >
> > > > >   #endif
> > > > > +
> > > > > +#ifdef CONFIG_CGROUP_MEM_RES_CTLR_KMEM
> > > gargh.  CONFIG_MEMCG_KMEM, please!
> >
> > Here too. I like it as much as you do.
> >
> > But that is consistent with the rest of the file, and I'd rather have
> > it this way.
>
> There's not much point in being consistent with something which is so
> unpleasant.  I'm on a little campaign to rename
> CONFIG_CGROUP_MEM_RES_CTLR to CONFIG_MEMCG, only nobody has taken my
> bait yet.  Be first!

If you are okay with a preparation mechanical patch to convert the whole 
file, I can change mine too.

But you'll be responsible for arguing with whoever stepping up opposing 
this =p

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/