Re: [PATCH 5/5] usb: gadget: composite: parse dt overrides

[Michal Nazarewicz]

> On 06/26/2012 09:27 AM, Alexandre Pereira da Silva wrote:
> > Grab the devicetree node properties to override VendorId, ProductId,
> > bcdDevice, Manucacturer, Product and SerialNumber

Like before, the code looks good to me:

Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>

Not commenting on the other aspects of the business logic though.

On Tue, 26 Jun 2012 20:43:03 +0200, Rob Herring <robherring2@xxxxxxxxx> wrote:
> I'm still confused about what is the order of priority for the 2
> possible sources of these values. The way it is written, the DT value is
> a default, not an override.

They are overwritten by module parameter but they are overwriting anything that
composite gadget might be providing.

--
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  MichaÅ âmina86â Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/