Re: [PATCH -v2 1/2] x86, microcode: Sanitize per-cpu microcodereloading interface

From: Borislav Petkov
Date: Tue Jun 26 2012 - 15:51:50 EST


On Tue, Jun 26, 2012 at 09:40:43PM +0200, Borislav Petkov wrote:
> > + put_online_cpus();
> > +
> > + if (pebs_broken == x86_pmu.pebs_broken)
>
> This is strange, why not:
>
> if (pebs_broken && x86_pmu.pebs_broken)
>
> ?
>
> > + return;

Ah, nevermind, I see what you're doing here.

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/