Re: [PATCH 8/8] release memory resources if hotadd_new_pgdat()failed

From: David Rientjes
Date: Wed Jun 27 2012 - 00:29:11 EST


On Tue, 26 Jun 2012, Wen Congyang wrote:

> We should goto error to release memory resource if hotadd_new_pgdat() failed.
>
> Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
> ---
> mm/memory_hotplug.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 2a14d35..3796690 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -617,7 +617,7 @@ int __ref add_memory(int nid, u64 start, u64 size)
> pgdat = hotadd_new_pgdat(nid, start);
> ret = -ENOMEM;
> if (!pgdat)
> - goto out;
> + goto error;
> new_pgdat = 1;
> }
>

This is a generic memory hotplug patch and doesn't rely on the rest of the
series, so let's cc the maintainer, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx>.

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/