Re: [PATCH] rtc: ds1307: Register offset moved to chip description

From: Wolfram Sang
Date: Wed Jun 27 2012 - 09:33:32 EST


On Wed, Jun 27, 2012 at 10:24:02AM +1200, Austin Boyle wrote:
> rtc: ds1307: Register offset moved to chip description
>
> From: Austin Boyle <Austin.Boyle@xxxxxxxxxxxx>
>
> Register offset is added to chip description instead of being hard-coded
> into probe function.
>
> Based on v3.5-rc4
>
> Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> Cc: Joakim Tjernlund <Joakim.Tjernlund@xxxxxxxxxxxx>
> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
> Signed-off-by: Austin Boyle <Austin.Boyle@xxxxxxxxxxxx>

I would ack this patch immediately if it added another type using this
feature. But only changing already working code doesn't seem necessary
to me.

Regards,

Wolfram

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

Attachment: signature.asc
Description: Digital signature