Re: [PATCH] perf: fix wrong hw_breakpoint documentation

From: Jovi Zhang
Date: Wed Jun 27 2012 - 09:40:36 EST


Hi Kim,

> It should be a bug in event parser. I guess the patch below will fix it:
>
>
> diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
> index 488362e14133..aafca33a8a09 100644
> --- a/tools/perf/util/parse-events.l
> +++ b/tools/perf/util/parse-events.l
> @@ -76,7 +76,7 @@ num_hex        0x[a-fA-F0-9]+
> Ânum_raw_hex  Â[a-fA-F0-9]+
> Âname      [a-zA-Z_*?][a-zA-Z0-9_*?]*
> Âmodifier_event [ukhpGH]{1,8}
> -modifier_bp  Â[rwx]
> +modifier_bp  Â[rwx]+
>

that should also be fine, but it will export rx/wx interface to user,
and rx/wx mostly not supported on many architecture.
Perhaps this issue is very tiny :)

[root@jovi perf]# ./perf stat -e mem:0x080652c8:rx Â-e mem:0x0 --
/usr/bin/ls > /dev/null

Performance counter stats for '/usr/bin/ls':

 <not supported> mem:0x80652c8:rx
        0 mem:(nil):rw

   0.006728643 seconds time elapsed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/