Re: should there still be arch-specific 4KSTACKS support?

[Greg Ungerer]

On 24/06/12 04:51, Geert Uytterhoeven wrote:
> Broadening the audience...
>
> On Sat, Jun 23, 2012 at 5:47 PM, Robert P. J. Day <rpjday@xxxxxxxxxxxxxx> wrote:
> >   via some convoluted logic, i ended up doing the following search:
> >
> > $ grep -r 4KSTACKS *
> > arch/sh/configs/r7785rp_defconfig:CONFIG_4KSTACKS=y
> > arch/sh/Kconfig.debug:config 4KSTACKS
> > arch/sh/include/asm/thread_info.h:#if defined(CONFIG_4KSTACKS)
> > arch/mn10300/include/asm/thread_info.h:#ifdef CONFIG_4KSTACKS
> > arch/m68k/Kconfig.machine:config 4KSTACKS
> > arch/m68k/configs/m5208evb_defconfig:# CONFIG_4KSTACKS is not set
> > arch/m68k/configs/m5275evb_defconfig:# CONFIG_4KSTACKS is not set
> > arch/m68k/configs/m5475evb_defconfig:# CONFIG_4KSTACKS is not set
> > arch/m68k/include/asm/thread_info.h:#ifdef CONFIG_4KSTACKS
> > arch/c6x/include/asm/thread_info.h:#ifdef CONFIG_4KSTACKS
> > drivers/lguest/interrupts_and_traps.c:   * Depending on the CONFIG_4KSTACKS option, the Guest can have one or
> > kernel/lockdep.c:        * hardirq contexts (such as on 4KSTACKS), so only
> > $
> >
> >   so even though 4KSTACKS support was officially removed in June of
> > 2010:
> >
> > $ git show dcfa7262
> >
> > there's still traces of it, some of it obviously harmless, leftover
> > cruft, but it would appear that both sh and m68k still provide a
> > 4KSTACKS config option.
> >
> >   how much of that can be tossed as useless?

Well, it still works on non-mmu m68k. Yes, I am aware of the issues,
but for those types of small memory non-mmu systems 4k stacks is a
saving. And those types of systems don't tend to use the parts of
the kernel that have been known to want lots of kernel stack.

But if opposition was incredibly strong to having anything support
4k stacks, I probably won't loose any sleep over it being removed
for m68k.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@xxxxxxxxxxxx
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/