Re: [PATCH v2 00/17] Big OMAP I2C Cleanup
From: Felipe Balbi
Date: Mon Jul 02 2012 - 07:39:41 EST
On Tue, Jun 26, 2012 at 04:21:30PM +0530, Shubhrajyoti wrote:
> On Thursday 14 June 2012 11:29 PM, Wolfram Sang wrote:
> >> - removed dev_err() which was introduced on patch 09/17
> > To prevent the list being flooded, I would appreciate if you could wait
> > a few days to collect reviews before resending. It will take some time
> > until I pick this series anyhow, because I want people to have time to
> > donate Tested-by tags.
> Felipe thats a good cleanup.
> The series look good to me.
> Also draining interrupt I had some queries.
> Looks good to me.
> I have tested it after rebasing.
rebasing on top of what ? You should resend the series so that I know
what changes you have made to my original patchset. Make sure to list on
the commit log what where the changes you made, so that it looks
something like this commit below where I changed commit log a bit:
| commit 3daf74d78dfcd552445c35f1b82a271ca305ceb9
| Author: Pratyush Anand <pratyush.anand@xxxxxx>
| Date: Sat Jun 23 02:23:08 2012 +0530
| usb: dwc3: remove WARN_ON from dwc_stop_active_transfer
| Now we are sure that, if res_trans_idx is zero, then endpoint has been
| stopped. So it's safe to just return if endpoint is already stopped. No
| need to generate warning anymore.
| While doing so, it's better to return when res_trans_idx is zero and
| decrease one level of indentation.
| Signed-off-by: Pratyush Anand <pratyush.anand@xxxxxx>
| [ balbi@xxxxxx: slightly changed commit log ]
| Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> Tested-by : Shubhrajyoti <shubhrajyoti@xxxxxx>
since you will send, you should, probably, add your Signed-off-by,
instead of Tested-by. dunno.
Description: Digital signature