Re: [PATCH 3/4] [SCSI] ufs: Add AMBA glue driver to ufshcd

[Arnd Bergmann]

On Monday 02 July 2012, Vinayak Holikatti wrote:
> +static struct amba_id ufshcd_amba_ids[] = {
> +       {
> +               /* Fake id for Primecell.*/
> +               .id     = 0x00041FF0,
> +               .mask   = 0x000fffff,
> +       },
> +       { 0, 0 },
> +};

Hi Vinayak,

Can you explain where this fake ID comes from? Is this ID actually
used by any hardware that is around somewhere? If not, I think it
would be better not to provide an AMBA driver at all, but instead
use the platform driver from patch 2 for all non-PCI uses.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/