RE: [PATCH 2/2] regulator: tps65217: Fix voltage boundary checkingin tps65217_pmic_map_voltage

From: AnilKumar, Chimata
Date: Tue Jul 03 2012 - 00:47:16 EST


Hi Axel,

On Tue, Jul 03, 2012 at 08:35:55, Axel Lin wrote:
> It is ok to request voltage with min_uV < tps->info[rid]->min_uV and
> max_uV > tps->info[rid]->max_uV
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
> drivers/regulator/tps65217-regulator.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/regulator/tps65217-regulator.c b/drivers/regulator/tps65217-regulator.c
> index 0a3df5b..0947a09 100644
> --- a/drivers/regulator/tps65217-regulator.c
> +++ b/drivers/regulator/tps65217-regulator.c
> @@ -206,10 +206,7 @@ static int tps65217_pmic_map_voltage(struct regulator_dev *dev,
> if (rid < TPS65217_DCDC_1 || rid > TPS65217_LDO_4)
> return -EINVAL;
>
> - if (min_uV < tps->info[rid]->min_uV || min_uV > tps->info[rid]->max_uV)
> - return -EINVAL;
> -
> - if (max_uV < tps->info[rid]->min_uV || max_uV > tps->info[rid]->max_uV)
> + if (max_uV < tps->info[rid]->min_uV || min_uV > tps->info[rid]->max_uV)
> return -EINVAL;

Case 1:-
------

tps->info[rid]->min_uV = 600000;
tps->info[rid]->max_uV = 1100000;

If we do regulator_set_voltage(reg, 550000, 1100000);

This results into error condition and how can we handle with this?

Case 2:-
------

I think the current code handles this case as well.

There might be a case where board/DT data is false like

tps->info[rid]->min_uV = 1100000;
tps->info[rid]->max_uV = 600000;

regulator_set_voltage(reg, 650000, 1100000);

Regards
AnilKumar--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/