Re: [PATCH 2/6] arm: fix compiler warning by properly inlining flat_set_persistent()

From: Ezequiel Garcia
Date: Tue Jul 03 2012 - 14:53:13 EST


Hi,

On Sat, Jun 9, 2012 at 5:13 AM, Ezequiel Garcia <elezegarcia@xxxxxxxxx> wrote:
> This patch removes the following warning:
> fs/binfmt_flat.c:752: warning: unused variable ‘persistent’
> There is neither change in functionality, nor extra code generated.
>
> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> Cc: <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ezequiel Garcia <elezegarcia@xxxxxxxxx>
> ---
> arch/arm/include/asm/flat.h | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/include/asm/flat.h b/arch/arm/include/asm/flat.h
> index 59426a4..6ef6cc5 100644
> --- a/arch/arm/include/asm/flat.h
> +++ b/arch/arm/include/asm/flat.h
> @@ -11,6 +11,11 @@
> #define flat_get_addr_from_rp(rp, relval, flags, persistent) get_unaligned(rp)
> #define flat_put_addr_at_rp(rp, val, relval) put_unaligned(val,rp)
> #define flat_get_relocate_addr(rel) (rel)
> -#define flat_set_persistent(relval, p) 0
> +
> +static inline int flat_set_persistent(unsigned long relval,
> + unsigned long *persistent)
> +{
> + return 0;
> +}
>
> #endif /* __ARM_FLAT_H__ */
> --
> 1.7.3.4
>

Is there something wrong with this patch preventing it from being applied?
Or did I send it to wrong list?

Thanks,
Ezequiel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/