Re: [PATCH 1/2 v2] HID: magicmouse: Removing report_touches switch

From: Daniel Kurtz
Date: Wed Jul 04 2012 - 03:50:07 EST


On Wed, Jul 4, 2012 at 3:40 PM, Henrik Rydberg <rydberg@xxxxxxxxxxx> wrote:
> On Tue, Jul 03, 2012 at 01:27:03PM -0700, Chase Douglas wrote:
>> On 07/03/2012 11:53 AM, Yufeng Shen wrote:
>> >Remove the report_touches switch as it is not so useful to turn
>> >off reporting touch events for a touch device. Let the userspace
>> >to do the filtering if the turning off is needed.
>> >
>> >V2: Remove report_touches as suggeted by Chase Douglas
>> >
>> >Signed-off-by: Yufeng Shen <miletus@xxxxxxxxxxxx>
>>
>> Acked-by: Chase Douglas <chase.douglas@xxxxxxxxxxxxx>
>
> Hi Chase,
>
> While testing the new patches, I noticed that only four fingers would
> come through; a fifth finger would make everything freeze. This
> behavior is also present without the new patches. Didn't we have ten
> fingers working at some point?
>
> Cheers,
> Henrik

Hi Henrik,

What Bluetooth host controller are you using?
Which part are you testing (Magic TP or mouse)?

I've been trying to test these patches on a Magic Trackpad using two
computers, with two different ath3k parts.
On one of them, the BT communication freezes immediately after the
first report with 3 fingers.
On the other, it reports all 10 fingers, just fine.

The only difference I can tell is the version of the Atheros Bluetooth chip.

What does your freeze look like?

-Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/