Re: [Patch] mm/policy: use int instead of unsigned for nid
From: Cong Wang
Date: Thu Jul 05 2012 - 09:37:49 EST
On Wed, 04 Jul 2012 at 06:43 GMT, David Rientjes <rientjes@xxxxxxxxxx> wrote:
> On Wed, 4 Jul 2012, Cong Wang wrote:
>> From: WANG Cong <xiyou.wangcong@xxxxxxxxx>
>> 'nid' should be 'int', not 'unsigned'.
> unsigned is already of type int, so you're saying these occurrences should
> become signed, but that's not true since they never return NUMA_NO_NODE.
> They are all safe returning unsigned.
Yeah, I knew, just thought using 'int' is consistent, this is a
trivial patch, not a bugfix.
> And alloc_page_interleave() doesn't exist anymore since the sched/numa
> bits were merged into sched/core, so nobody could apply this patch anyway.
Ah, I made this patch against linus tree...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/