Re: [PATCH] of: address: Don't fail a lookup just because a nodehas no reg property

From: Lee Jones
Date: Thu Jul 05 2012 - 11:17:32 EST

On 05/07/12 15:57, Rob Herring wrote:
On 07/05/2012 09:32 AM, Lee Jones wrote:
Sometimes it doesn't make any sense for a node to have an address.
In this case device lookup will always be unsuccessful because we
currently assume every node will have a reg property. This patch
changes the semantics so that the resource address and the lookup
address will only be compared if one exists.

Things like AUXDATA() rely on of_dev_lookup to return the lookup
entry of a particular device in order to do things like apply
platform_data to a device. However, this is currently broken for
nodes which do not have a reg property, meaning that platform_data
can not be passed in those cases.

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Acked-by: Rob Herring <rob.herring@xxxxxxxxxxx>

Do you have something dependent on this or want me to apply?

I have things that require this patch yes. Please apply.

Thanks Rob.

Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515 â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at