Re: [PATCH 15/19] Staging: xgifb: Rework conditions inXGI_SetLockRegs().

From: Aaro Koskinen
Date: Thu Jul 05 2012 - 14:00:37 EST


Hi,

On Thu, Jul 05, 2012 at 04:45:58PM +0200, Miguel Gómez wrote:
> + if ((pVBInfo->VBType & VB_SIS301LV) &&
> + !(pVBInfo->TVInfo & TVSetHiVision)) {
> + if ((pVBInfo->TVInfo & TVSimuMode) &&
> + (pVBInfo->TVInfo & TVSetPAL)) {
> + if (pVBInfo->VBType & VB_SIS301LV) {
> + if (!(pVBInfo->TVInfo &
> + (TVSetYPbPr525p |
> + TVSetYPbPr750p |
> + TVSetHiVision)))
> + tempbx += 40;
> + } else {
> + tempbx += 40;

I think this could be simplified even more - both branches end up doing
the same?!

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/