Re: [PATCH 01/10] random: make 'add_interrupt_randomness()' dosomething sane

From: Linus Torvalds
Date: Thu Jul 05 2012 - 14:52:34 EST


On Thu, Jul 5, 2012 at 11:47 AM, Matt Mackall <mpm@xxxxxxxxxxx> wrote:
>
> I think you should demand a minimum number of events > HZ to actually
> credit any valid entropy.

There already is. It's 1.

If we don't get a single non-timer interrupt, this code will never be called.

And if we only get a single interrupt in over one HZ, then there very
arguably is one bit of entropy in 'jiffies' at the time of that
interrupt.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/