Re: Add MEDIATEK products to option driver

[gaosen]

Dear sshtylyov,

        Thanks for your comments, I will change it later.

BR, Gaosen

-----Original Message-----
From: Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxx]
Sent: 2012年7月6日 20:10
To: Gaosen Zhang (张高森)
Cc: smurf@xxxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx;
linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: Add MEDIATEK products to option driver

Hello.

On 05-07-2012 17:49, gaosen wrote:

>  From bb4d2a7155393b5d1207c398c3f9644898588e8a Mon Sep 17 00:00:00
> 2001
> From: "gaosen.zhang" <gaosen.zhang@xxxxxxxxxxxx>
> Date: Thu, 5 Jul 2012 20:01:54 +0800
> Subject: [PATCH 1/1] Add MEDIATEK products to option driver


> Signed-off-by: gaosen.zhang <gaosen.zhang@xxxxxxxxxxxx>

    Why not simply Gaosen Zhang?

> ---
>   drivers/usb/serial/option.c |   20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)

> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index e668a24..3d47661 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -496,6 +496,15 @@ static void option_instat_callback(struct urb
> *urb);
>
>   /* MediaTek products */
>   #define MEDIATEK_VENDOR_ID			0x0e8d
> +#define MEDIATEK_PRODUCT_DC_1COM		0x00a0
> +#define MEDIATEK_PRODUCT_DC_4COM		0x00a5
> +#define MEDIATEK_PRODUCT_DC_5COM		0x00a4
> +#define MEDIATEK_PRODUCT_7208_1COM		0x7101
> +#define MEDIATEK_PRODUCT_7208_2COM		0x7102
> +#define MEDIATEK_PRODUCT_FP_1COM		0x0003
> +#define MEDIATEK_PRODUCT_FP_2COM		0x0023
> +#define MEDIATEK_PRODUCT_FPDC_1COM		0x0043
> +#define MEDIATEK_PRODUCT_FPDC_2COM		0x0033

    Shouldn't these be sorted by numeric value?

> @@ -1233,6 +1242,17 @@ static const struct usb_device_id option_ids[] = {
>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff,
> 0x02, 0x01) },
>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
> 0x00, 0x00) },
>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
> 0x02, 0x01) },        /* MediaTek MT6276M modem & app port */
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_1COM, 0x0a, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_5COM, 0xff, 0x02, 0x01) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_5COM, 0xff, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_4COM, 0xff, 0x02, 0x01) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_DC_4COM, 0xff, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_7208_1COM, 0x02, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_7208_2COM, 0x02, 0x02, 0x01) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_FP_1COM, 0x0a, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_FP_2COM, 0x0a, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_FPDC_1COM, 0x0a, 0x00, 0x00) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID,
> MEDIATEK_PRODUCT_FPDC_2COM, 0x0a, 0x00, 0x00) },

    Your patch is line wrapped.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/