Re: [PATCH 1/3] staging: vt6656: iwctl: fix up spacing aroundoperators

[Jesper Juhl]

On Sun, 8 Jul 2012, Joe Perches wrote:

> On Mon, 2012-07-09 at 00:58 +0200, Jesper Juhl wrote:
> > A few cases were missed in my previous cleanup, this takes care of the
> > last cases of missing space (or too much space (as in a newline))
> > around operators ('=', '==', ',', '<').
> 
> Trivia:
> 
> > diff --git a/drivers/staging/vt6656/iwctl.c b/drivers/staging/vt6656/iwctl.c
> []
> > @@ -1624,8 +1624,7 @@ int iwctl_siwmlme(struct net_device *dev, struct iw_request_info *info,
> >  	case IW_MLME_DISASSOC:
> >  		if (pDevice->bLinkPass == TRUE) {
> >  			PRINT_K("iwctl_siwmlme--->send DISASSOCIATE\n");
> > -			bScheduleCommand((void *)pDevice,
> > -					WLAN_CMD_DISASSOCIATE,
> > +			bScheduleCommand((void *)pDevice, WLAN_CMD_DISASSOCIATE,
> >  					NULL);
> 
> pDevice doesn't need a cast.
> 
> bScheduleCommand uses a lot of casts for pDevice
> that aren't necessary.
> 
Right you are.

I have not gone through the file to verify all casts (yet). I was focused 
on getting it from the totally chaotic state it was in to something that 
was readable and reasonably close to CodingStyle. I'm well aware that it's 
not perfect (yet).

I'm a bit out of time right now and for the next couple of days, but I can 
probably do a review of the casts and send some follow-up patches later in 
the week.

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/