Re: [PATCH 03/16] sched: aggregate load contributed by task entitieson parenting cfs_rq

From: Ingo Molnar
Date: Mon Jul 09 2012 - 05:15:17 EST



* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Wed, 2012-07-04 at 17:28 +0200, Peter Zijlstra wrote:
> > On Wed, 2012-06-27 at 19:24 -0700, Paul Turner wrote:
> > > For a given task t, we can compute its contribution to load as:
> > > task_load(t) = runnable_avg(t) * weight(t)
> > >
> > > On a parenting cfs_rq we can then aggregate
> > > runnable_load(cfs_rq) = \Sum task_load(t), for all runnable children t
> > >
> > > Maintain this bottom up, with task entities adding their contributed load to
> > > the parenting cfs_rq sum. When a task entities load changes we add the same
> > > delta to the maintained sum.
> > >
> > > Signed-off-by: Paul Turner <pjt@xxxxxxxxxx>
> > > Signed-off-by: Ben Segall <bsegall@xxxxxxxxxx>
> >
> > A lot of patches have this funny sob trail.. Ben never send me these
> > patches, so uhm. ?
> >
> > Should that be Reviewed-by, or what is the deal with those?
>
> Ben could you clarify what your exact contribution was?
>
> Ingo, supposing Ben is co-author and wrote a significant part
> of the patch, what are we supposed to do with these tags?

There can be only one author SOB - additional contributions
should be reflected via credits in the changelog, copyright
lines and/or Originally-From: tags, or so.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/