Re: [PATCH] sdio: Change pr_warning to pr_warn_ratelimited

From: Chris Ball
Date: Mon Jul 09 2012 - 06:30:30 EST


Hi,

On Thu, Jun 14 2012, Liu, Chuansheng wrote:
> From: liu chuansheng <chuansheng.liu@xxxxxxxxx>
> Subject: [PATCH] sdio: Change pr_warning to pr_warn_ratelimited
>
> When debug one bad issue, got lots of pr_warning messages
> "queuing unknown CIS tuple" which caused the printk storm
> and flooded the console.
>
> This patch is changing the pr_warning api to pr_warn_ratelimited.
>
> Signed-off-by: liu chuansheng <chuansheng.liu@xxxxxxxxx>
> ---
> drivers/mmc/core/sdio_cis.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/core/sdio_cis.c b/drivers/mmc/core/sdio_cis.c
> index f1c7ed8..8e94e55 100644
> --- a/drivers/mmc/core/sdio_cis.c
> +++ b/drivers/mmc/core/sdio_cis.c
> @@ -313,7 +313,7 @@ static int sdio_read_cis(struct mmc_card *card, struct sdio_func *func)
>
> if (ret == -ENOENT) {
> /* warn about unknown tuples */
> - pr_warning("%s: queuing unknown"
> + pr_warn_ratelimited("%s: queuing unknown"
> " CIS tuple 0x%02x (%u bytes)\n",
> mmc_hostname(card->host),
> tpl_code, tpl_link);

Thanks, pushed to mmc-next for 3.6.

- Chris.
--
Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/