Re: [PATCH 2/8] staging/ft1000: fix the spaces issue at the start ofline

From: Greg KH
Date: Mon Jul 09 2012 - 15:25:40 EST


On Sat, Jul 07, 2012 at 05:35:13PM +0530, Devendra Naga wrote:
> The following warns fixed
>
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:2032: ERROR: code indent should use tabs where possible
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:2032: WARNING: please, no spaces at the start of a line
>
> Signed-off-by: Devendra Naga <devendra.aaru@xxxxxxxxx>
> ---
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> index 0bd080c..c709671 100644
> --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> @@ -2029,7 +2029,7 @@ static irqreturn_t ft1000_interrupt(int irq, void *dev_id)
> ft1000_write_reg(dev, FT1000_REG_SUP_ISR, tempword);
>
> // Read interrupt type
> - inttype = ft1000_read_reg (dev, FT1000_REG_SUP_ISR);
> + inttype = ft1000_read_reg (dev, FT1000_REG_SUP_ISR);

Did you just indent this one too many tabs? Remember, a tab is 8
spaces, this should have lined up wit the line above it. Which, for
some odd reason, is also using spaces, so why didn't that get fixed
also?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/