Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

From: Lee Jones
Date: Mon Jul 09 2012 - 16:34:36 EST


Why do you keep these assignments and then override them with
translations? Why don't you do

ponkey->idev = input;
ponkey->ab8500 = ab8500;
ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf);
ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr);

to begin with?

Ah, I see what you mean now.

Sorry, just glossed over your first email.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/