Re: [PATCH] mm: don't invoke __alloc_pages_direct_compact whenorder 0

From: Andrew Morton
Date: Mon Jul 09 2012 - 18:40:59 EST


On Mon, 9 Jul 2012 23:13:50 +0900
JoonSoo Kim <js1304@xxxxxxxxx> wrote:

> >> In my kernel image, __alloc_pages_direct_compact() is not inlined by gcc.

My gcc-4.4.4 doesn't inline it either.

> I think __alloc_pages_direct_compact() can't be inlined by gcc,
> because it is so big and is invoked two times in __alloc_pages_nodemask().

This. Large function, two callsites.

Making __alloc_pages_direct_compact() __always_inline adds only 26
bytes to my page_alloc.o's .text. Such is the suckiness of passing
eleven arguments!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/