Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQmapping

From: Dmitry Torokhov
Date: Tue Jul 10 2012 - 02:18:00 EST


On Mon, Jul 09, 2012 at 10:59:43PM +0200, Lee Jones wrote:
> Sorry for the cock-up(s).
>
> From: Lee Jones <lee.jones@xxxxxxxxxx>
> Date: Tue, 26 Jun 2012 10:46:50 +0100
> Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping
>
> Before we can use any domain allocated IRQ, we need to first create a
> map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq).
> We do this with a helper function provided by the AB8500 IRQ domain
> controller called ab8500_irq_get_virq(). We need to do this for both
> IRQs which the Power-On-Key driver uses; one for button press, the other
> for button depress.
>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

I think it would be best if this got merged through whatever tree that
was used to introduce ab8500_irq_get_virq(); otherwise it will have to
wait till I resync with mainline sometime in the middle of the next
release cycle.

Thanks.

> ---
> drivers/input/misc/ab8500-ponkey.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c
> index 5ceb23e..f6764af 100644
> --- a/drivers/input/misc/ab8500-ponkey.c
> +++ b/drivers/input/misc/ab8500-ponkey.c
> @@ -74,8 +74,8 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev)
>
> ponkey->idev = input;
> ponkey->ab8500 = ab8500;
> - ponkey->irq_dbf = irq_dbf;
> - ponkey->irq_dbr = irq_dbr;
> + ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf);
> + ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr);
>
> input->name = "AB8500 POn(PowerOn) Key";
> input->dev.parent = &pdev->dev;
> --
> 1.7.9.5
>
>
>

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/