Re: [PATCH v1 07/11] drivers: usb: twl4030: Add device tree supportfor twl4030 usb

[Rajendra Nayak]

On Tuesday 10 July 2012 12:22 PM, ABRAHAM, KISHON VIJAY wrote:
> > > +TWL4030 USB PHY AND COMPARATOR
> > > >>  + - compatible : Should be "ti,twl4030-usb"
> > > >>  + - interrupts : The interrupt numbers to the cpu should be specified.
> > > >>  First
> > > >>  +   interrupt number is the otg interrupt number that raises ID interrupts
> > > >>  +   and VBUS interrupts. The second interrupt number is optional.
> > > >>  + -<supply-name>-supply : phandle to the regulator device tree node.
> > > >>  +<supply-name>   should be vusb1v5, vusb1v8 and vusb3v1
> > > >>  + - usb_mode : The mode used by the phy to connect to the controller. "1"
> > > >>  +   specifies "ULPI" mode and "2" specifies "CEA2011_3PIN" mode.
> > >
> > >
> > >  Are these standard usb phy modes or something specific to the twl4030
> > >  usb phy?
> These are standard modes used to connect the phy to the controller. I
> think it's used by other chips other than twl4030 (Something in
> am35xx??).

So would it make sense to document these bindings independent of a given
phy and a given controller, so it could be reused and not duplicated in
various forms for various different controllers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/